Fix hang on UTF-16 LE BOM file#636
Conversation
|
Yeah - there's several places which lack checks for |
|
With #647 it should be possible to write a test which uses the input in question. |
Can we just run the tests with all three options? |
Yes, if somebody adds the functionality. It didn't seem straight forward to me so I haven't yet. Feel free to do so. |
|
I think I took a wrong turn. That should trigger with regular unit test. So please add a test for it. |
Ah - you mentioned |
|
So there is also some kind of platform divergence going on... |
|
These (hanging) runs may be cancelled by the way: |
Of course |
|
I guess CI will be fixed by #641 |
|
@chrchr-github I want to release simplecpp so we can update cppcheck repo before the release. do you want to merge now to get this into the release or rather wait? |
|
I have approved it, as far as I see it can be merged into the release. |
It's also a hang in cppcheck, so we might as well merge it (I don't have permission though). |
fixes #637